Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Await schema agreement post migration #106

Closed
mmatczuk opened this issue Jun 19, 2019 · 7 comments
Closed

Await schema agreement post migration #106

mmatczuk opened this issue Jun 19, 2019 · 7 comments

Comments

@mmatczuk
Copy link
Contributor

This requires a patch to gocql. Gocql has a function awaitSchemaAgreement to wait for schema to be propagated to all the nodes. We should export that to Session. When done we should call it post each migration.

@dahankzter
Copy link
Contributor

So the normal notification flow here isn't enough? Is it just too slow to pick up on that?

@mmatczuk
Copy link
Contributor Author

Waiting for keyspace changed events will not work, for instance if you only add data there is not keyspace change.

@powerman
Copy link

Is there any workaround which can be used right now?

@mmatczuk
Copy link
Contributor Author

Yes use a single host to run all the migrations. You can check that by issuing describe schema queries to different hosts.

@annismckenzie
Copy link
Contributor

I'm working on this in #133. Still working out the kinks (gocql test suite is failing for some combinations on Travis, incidentally only those that have auth enabled – weird).

@mmatczuk
Copy link
Contributor Author

Kudos for working on it.

@mmatczuk
Copy link
Contributor Author

Fixed in #133

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants