-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unify binary, repo and image naming #39
Comments
The Scylla Operator project currently lacks enough contributors to adequately respond to all issues. This bot triages un-triaged issues according to the following rules:
You can:
/lifecycle stale |
/remove-lifecycle stale |
I collected pros and cons behind few options we discussed, here's a summary: Change k8s-local-volume-provisioner to local-csi-driver
What needs to be done afterwards:
Change local-csi-driver to k8s-local-volume-provisioner
What needs to be done afterwards:
Change k8s-local-volume-provisioner to scylladb-local-csi(-driver)
What needs to be done afterwards:
I had a meeting with @ylebi where we discussed them, and we are align on opting to the first option. |
Thanks for writing this down. I'd generally be in favour of using
Kind of, but the name is generic enough for other people writing a CSI driver to pick the same name and conflict with us. Having such prefix is pretty common practice to avoid collisions on naming. That said, going for the first option But please start by renaming the repo, so the opinionated part (which is how this discrepancy came to be) will be sorted out. |
Rename k8s-local-volume-provisioner to local-csi-driver
Rename k8s-local-volume-provisioner to local-csi-driver Update pkg/cmd/local-csi-driver/driver.go Co-authored-by: Tomáš Nožička <tnozicka@users.noreply.github.com> Update pkg/cmd/local-csi-driver/driver.go Update pkg/cmd/local-csi-driver/driver.go Update test/e2e/set/localdriver/upstream.go Update test/e2e/set/localdriver/upstream.go Co-authored-by: Tomáš Nožička <tnozicka@users.noreply.github.com> Update test/e2e/set/localdriver/upstream.go Update README.md
We should unify the packages, binary and image name for consistency.
At this point the difference is confusing (caused by historical reasons when requesting the repo name):
repo name:
github.com/scylladb/k8s-local-volume-provisioner
image name:
docker.io/scylladb/k8s-local-volume-provisioner
binary name:
local-csi-driver
The text was updated successfully, but these errors were encountered: