Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add info to each of the balance signs #1166

Closed
tzach opened this issue Dec 10, 2020 · 5 comments · Fixed by #1334
Closed

Add info to each of the balance signs #1166

tzach opened this issue Dec 10, 2020 · 5 comments · Fixed by #1334
Assignees

Comments

@tzach
Copy link
Contributor

tzach commented Dec 10, 2020

#1162 adds signs for balanced (or imbalance) metrics, like connections, CQL Traffic, Node Latency etc. For each, we need to explain what metric is measured, and when it is become imbalance (formula)
The first is unique per metric
The later can be explain in docs, and we can point to it

For example, Connections:
is it just CQL? what about alternator? internal connections? Is it per node or core?

Example wording
The number of CQL (over TCP) connection from clients (drivers) to each Scylla Node

@amnonh
Copy link
Collaborator

amnonh commented Dec 10, 2020

@tzach have you look at the information each of them already has?

@amnonh
Copy link
Collaborator

amnonh commented Dec 15, 2020

@tzach ping

@amnonh amnonh added this to the monitoring 3.7 milestone Jan 14, 2021
@tzach
Copy link
Contributor Author

tzach commented Mar 15, 2021

have you look at the information each of them already has?

@amnonh not sure to which version the original issue was referring (shame on me for not including it)
Can you please point me to this info?

@amnonh
Copy link
Collaborator

amnonh commented Mar 15, 2021

@tzach you can either run the latest and check if that's enough or look a the dashboard code starting from here:

@tzach
Copy link
Contributor Author

tzach commented Mar 21, 2021

I do not think the current descriptions are clear enough.

For example:
"Indicates that the CQL traffic is not unified between shards"

  • is this metric for CQL connection, CQL operations (which?), or something else (we are not using "traffic" elsewhere)
  • Is the imbalance of shared in one node, or of sum (or average?) of the same share number across all nodes?

I suggest something more explicit like:

"Indicates that the number of CQL operations (inserts, updates, deletes, reads) is not balance between shards in a node"

(which node?)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants