cluster_validation_test.go

package v1alpha1_test

import (
	"testing"

	"github.com/scylladb/scylla-operator/pkg/api/v1alpha1"
	"github.com/scylladb/scylla-operator/pkg/test/unit"
	"github.com/stretchr/testify/require"
	corev1 "k8s.io/api/core/v1"
	"k8s.io/apimachinery/pkg/api/resource"
	"k8s.io/utils/pointer"
)

func TestCheckValues(t *testing.T) {
	validCluster := unit.NewSingleRackCluster(3)
	validCluster.Spec.Datacenter.Racks[0].Resources = corev1.ResourceRequirements{
		Limits: map[corev1.ResourceName]resource.Quantity{
			corev1.ResourceCPU:    resource.MustParse("2"),
			corev1.ResourceMemory: resource.MustParse("2Gi"),
		},
	}

	sameName := validCluster.DeepCopy()
	sameName.Spec.Datacenter.Racks = append(sameName.Spec.Datacenter.Racks, sameName.Spec.Datacenter.Racks[0])

	invalidIntensity := validCluster.DeepCopy()
	invalidIntensity.Spec.Repairs = append(invalidIntensity.Spec.Repairs, v1alpha1.RepairTaskSpec{
		Intensity: pointer.StringPtr("100Mib"),
	})

	tests := []struct {
		name    string
		obj     *v1alpha1.ScyllaCluster
		allowed bool
	}{
		{
			name:    "valid",
			obj:     validCluster,
			allowed: true,
		},
		{
			name:    "two racks with same name",
			obj:     sameName,
			allowed: false,
		},
		{
			name:    "invalid intensity in repair task spec",
			obj:     invalidIntensity,
			allowed: false,
		},
	}

	for _, test := range tests {
		t.Run(test.name, func(t *testing.T) {
			err := v1alpha1.CheckValues(test.obj)
			if test.allowed {
				require.NoError(t, err, "Wrong value returned from checkValues function. Message: '%s'", err)
			} else {
				require.Error(t, err, "Wrong value returned from checkValues function. Message: '%s'", err)
			}
		})
	}
}

func TestCheckTransitions(t *testing.T) {
	tests := []struct {
		name    string
		old     *v1alpha1.ScyllaCluster
		new     *v1alpha1.ScyllaCluster
		allowed bool
	}{
		{
			name:    "same as old",
			old:     unit.NewSingleRackCluster(3),
			new:     unit.NewSingleRackCluster(3),
			allowed: true,
		},

		{
			name:    "major version changed",
			old:     unit.NewSingleRackCluster(3),
			new:     unit.NewDetailedSingleRackCluster("test-cluster", "test-ns", "repo", "3.3.1", "test-dc", "test-rack", 3),
			allowed: false,
		},
		{
			name:    "minor version changed",
			old:     unit.NewSingleRackCluster(3),
			new:     unit.NewDetailedSingleRackCluster("test-cluster", "test-ns", "repo", "2.4.2", "test-dc", "test-rack", 3),
			allowed: false,
		},
		{
			name:    "patch version changed",
			old:     unit.NewSingleRackCluster(3),
			new:     unit.NewDetailedSingleRackCluster("test-cluster", "test-ns", "repo", "2.3.2", "test-dc", "test-rack", 3),
			allowed: true,
		},
		{
			name:    "repo changed",
			old:     unit.NewSingleRackCluster(3),
			new:     unit.NewDetailedSingleRackCluster("test-cluster", "test-ns", "new-repo", "2.3.2", "test-dc", "test-rack", 3),
			allowed: false,
		},
		{
			name:    "dcName changed",
			old:     unit.NewSingleRackCluster(3),
			new:     unit.NewDetailedSingleRackCluster("test-cluster", "test-ns", "repo", "2.3.1", "new-dc", "test-rack", 3),
			allowed: false,
		},
		{
			name:    "rackPlacement changed",
			old:     unit.NewSingleRackCluster(3),
			new:     placementChanged(unit.NewSingleRackCluster(3)),
			allowed: false,
		},
		{
			name:    "rackStorage changed",
			old:     unit.NewSingleRackCluster(3),
			new:     storageChanged(unit.NewSingleRackCluster(3)),
			allowed: false,
		},
		{
			name:    "rackResources changed",
			old:     unit.NewSingleRackCluster(3),
			new:     resourceChanged(unit.NewSingleRackCluster(3)),
			allowed: false,
		},
		{
			name:    "rack deleted",
			old:     unit.NewSingleRackCluster(3),
			new:     rackDeleted(unit.NewSingleRackCluster(3)),
			allowed: false,
		},
	}

	for _, test := range tests {
		t.Run(test.name, func(t *testing.T) {
			err := v1alpha1.CheckTransitions(test.old, test.new)
			if test.allowed {
				require.NoError(t, err, "Wrong value returned from checkTransitions function. Message: '%s'", err)
			} else {
				require.Error(t, err, "Wrong value returned from checkTransitions function. Message: '%s'", err)
			}
		})
	}
}

func placementChanged(c *v1alpha1.ScyllaCluster) *v1alpha1.ScyllaCluster {
	c.Spec.Datacenter.Racks[0].Placement = &v1alpha1.PlacementSpec{}
	return c
}

func resourceChanged(c *v1alpha1.ScyllaCluster) *v1alpha1.ScyllaCluster {
	c.Spec.Datacenter.Racks[0].Resources.Requests = map[corev1.ResourceName]resource.Quantity{
		corev1.ResourceCPU: *resource.NewMilliQuantity(1000, resource.DecimalSI),
	}
	return c
}

func rackDeleted(c *v1alpha1.ScyllaCluster) *v1alpha1.ScyllaCluster {
	c.Spec.Datacenter.Racks = nil
	return c
}

func storageChanged(c *v1alpha1.ScyllaCluster) *v1alpha1.ScyllaCluster {
	c.Spec.Datacenter.Racks[0].Storage.Capacity = "15Gi"
	return c
}