Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chunked_vector crashes in certain cases if reserve() is called twice without the reservation being consumed #10363

Closed
avikivity opened this issue Apr 12, 2022 · 1 comment
Closed

chunked_vector crashes in certain cases if reserve() is called twice without the reservation being consumed #10363

avikivity opened this issue Apr 12, 2022 · 1 comment
Milestone
5.1

Comments

@avikivity
Copy link
Member

Found by @tgrabiec via code review:

Found during code review, no known user impact.
avikivity pushed a commit that referenced this issue Apr 13, 2022
@tgrabiec @avikivity
utils/chunked_vector: Fix sigsegv during reserve()
2c6f069 
Fixes the case of make_room() invoked with last_chunk_capacity_deficit
but _size not in the last reserved chunk.

Found during code review, no known user impact.

Fixes #10363.

Message-Id: <20220411222605.641614-1-tgrabiec@scylladb.com>
(cherry picked from commit 01eeb33)
avikivity pushed a commit that referenced this issue Apr 13, 2022
@tgrabiec @avikivity
utils/chunked_vector: Fix sigsegv during reserve()
fb91539 
Fixes the case of make_room() invoked with last_chunk_capacity_deficit
but _size not in the last reserved chunk.

Found during code review, no known user impact.

Fixes #10363.

Message-Id: <20220411222605.641614-1-tgrabiec@scylladb.com>
(cherry picked from commit 01eeb33)
avikivity pushed a commit that referenced this issue Apr 13, 2022
@tgrabiec @avikivity
utils/chunked_vector: Fix sigsegv during reserve()
8464002 
Fixes the case of make_room() invoked with last_chunk_capacity_deficit
but _size not in the last reserved chunk.

Found during code review, no known user impact.

Fixes #10363.

Message-Id: <20220411222605.641614-1-tgrabiec@scylladb.com>
(cherry picked from commit 01eeb33)
@avikivity
Copy link
Member Author

Backported to 4.5, 4.6, 5,0 (just in case)

avikivity pushed a commit that referenced this issue Apr 13, 2022
@tgrabiec @avikivity
utils/chunked_vector: Fix sigsegv during reserve()
e50452b 
Fixes the case of make_room() invoked with last_chunk_capacity_deficit
but _size not in the last reserved chunk.

Found during code review, no known user impact.

Fixes #10363.

Message-Id: <20220411222605.641614-1-tgrabiec@scylladb.com>
(cherry picked from commit 01eeb33)

[avi: make max_chunk_capacity() public for backport]
avikivity pushed a commit that referenced this issue Apr 13, 2022
@tgrabiec @avikivity
utils/chunked_vector: Fix sigsegv during reserve()
48d4759 
Fixes the case of make_room() invoked with last_chunk_capacity_deficit
but _size not in the last reserved chunk.

Found during code review, no known user impact.

Fixes #10363.

Message-Id: <20220411222605.641614-1-tgrabiec@scylladb.com>
(cherry picked from commit 01eeb33)

[avi: make max_chunk_capacity() public for backport]
benipeled pushed a commit to benipeled/scylla that referenced this issue May 31, 2022
@tgrabiec @avikivity
utils/chunked_vector: Fix sigsegv during reserve()
88e3c3c 
Fixes the case of make_room() invoked with last_chunk_capacity_deficit
but _size not in the last reserved chunk.

Found during code review, no known user impact.

Fixes scylladb#10363.

Message-Id: <20220411222605.641614-1-tgrabiec@scylladb.com>
(cherry picked from commit 01eeb33)

[avi: make max_chunk_capacity() public for backport]
@DoronArazii DoronArazii added this to the 5.0 milestone Jul 7, 2022
@DoronArazii DoronArazii modified the milestones: 5.0, 5.1 Nov 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
5.1
Development

No branches or pull requests
4 participants
@avikivity @mykaul @scylladb-promoter @DoronArazii