Alternator: Support new DeletionProtectionEnabled feature #14482
Labels
area/alternator
Alternator related Issues
Milestone
Comments
nyh
added a commit
to nyh/scylla
that referenced
this issue
Jul 3, 2023
This patch adds to docs/alternator/compatibility.md mentions of three recently-added DynamoDB features (ReturnValuesOnConditionCheckFailure, DeletionProtectionEnabled and TableClass) which Alternator does not yet support. Each of these mentions also links to the github issue we have on each feature - issues scylladb#14481, scylladb#14482 and scylladb#10431 respectively. Signed-off-by: Nadav Har'El <nyh@scylladb.com>
nyh
added a commit
to nyh/scylla
that referenced
this issue
Jul 12, 2023
This patch adds to docs/alternator/compatibility.md mentions of three recently-added DynamoDB features (ReturnValuesOnConditionCheckFailure, DeletionProtectionEnabled and TableClass) which Alternator does not yet support. Each of these mentions also links to the github issue we have on each feature - issues scylladb#14481, scylladb#14482 and scylladb#10431 respectively. During a review of this patch, the reviewers didn't like that I used words like "recent" and "new" to describe recently-added DynamoDB features, and asked that I use specific dates instead. So this is what I do in this patch for the new features - and I also went back and fixed a few pre-existing references to "recent" and "new" features, and added the dates. Signed-off-by: Nadav Har'El <nyh@scylladb.com>
kbr-scylla
pushed a commit
that referenced
this issue
Jul 13, 2023
This patch adds to docs/alternator/compatibility.md mentions of three recently-added DynamoDB features (ReturnValuesOnConditionCheckFailure, DeletionProtectionEnabled and TableClass) which Alternator does not yet support. Each of these mentions also links to the github issue we have on each feature - issues #14481, #14482 and #10431 respectively. During a review of this patch, the reviewers didn't like that I used words like "recent" and "new" to describe recently-added DynamoDB features, and asked that I use specific dates instead. So this is what I do in this patch for the new features - and I also went back and fixed a few pre-existing references to "recent" and "new" features, and added the dates. Signed-off-by: Nadav Har'El <nyh@scylladb.com> Closes #14483
|
Looks nice, do you have a plan for implementing the feature recently? |
Rjerk
added a commit
to Rjerk/scylla
that referenced
this issue
Jul 28, 2023
When the deletion protection property is enabled for a table, the table cannot be deleted. Now 'DeletionProtectionEnabled' is fully supported in CreateTable/UpdateTable/DescribeTable/DeleteTable. Signed-off-by: Liu Lan <liulan_yewu@cmss.chinamobile.com> Closes scylladb#14482
|
Recently our maintainer of ScyllaDB accidentally deleted a table causing data loss. Fortunately, there are snapshots to restore the data. However, supporting the table protection function is necessary, so I started to implement it: #14864 Can you review it for me? |
Rjerk
added a commit
to Rjerk/scylla
that referenced
this issue
Aug 1, 2023
When the deletion protection property is enabled for a table, the table cannot be deleted. Now 'DeletionProtectionEnabled' is fully supported in CreateTable/UpdateTable/DescribeTable/DeleteTable. Signed-off-by: Liu Lan <liulan_yewu@cmss.chinamobile.com> Closes scylladb#14482
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
As recently announced in https://aws.amazon.com/about-aws/whats-new/2023/03/amazon-dynamodb-table-deletion-protection/, DynamoDB added a new option for tables,
DeletionProtectionEnabled. This option can be set or unset on a table withCreateTableandUpdateTable. If set for a table, the table cannot be deleted withDeleteTable.This is not a security feature and is separate from IAM support (#5047) - a user can still delete any table by first disabling its
DeletionProtectionEnabledprotection, and then deleting it. This feature was only meant as a way to protect against accidental deletion of tables.The text was updated successfully, but these errors were encountered: