New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add duration type #2240
Comments
I've finished porting the underlying However, it looks like this feature was introduced in the 3.10 release of Cassandra, so we may want to wait before supporting the new type in CQL. I could prepare a patch for merging the support for the underlying type and we could revisit this in the future. Do you have any input, @tzach? |
For reference, the patch which adds this feature is discussed here. |
By itself the fact it was added to Cassandra only in 3.10 shouldn't block us. But it looks like duration can't be represented in cql binary protocol < v5, and we only support v4 so far. |
@avikivity CQL protocol v5 is work-in-progress, hidden behind some feature flag in the drivers. We can definitely add support for that in ScyllaDB for the duration type. |
Cassandra 3.10 added the `duration` type [1], intended to manipulate date-time values with offsets (for example, `now() - 2y3h`). The full implementation of the `duration` type in Scylla requires support for version 5 of the binary protocol, which is not yet available. In the meantime, this patch patch adds the implementation of the underlying type for the eventual `duration` type. Included is also the ported test suite from the reference implementation and additional tests. Related to #2240. [1] https://issues.apache.org/jira/browse/CASSANDRA-11873 Signed-off-by: Jesse Haber-Kucharsky <jhaberku@scylladb.com> Message-Id: <b1e481da103efee82106bf31f261c5a1f4f8d9ca.1499885803.git.jhaberku@scylladb.com>
@hakuch what driver can work with this new type? (and v5)? |
Yes it does. Thanks |
…zed bytes context Resetting the state involves comparing keys. If these are large, they'll have to be linearized and hence this has to happen in a linearized bytes context. Refs: scylladb#2240 Closes scylladb#2241 Upstream: 60f5ec3
Cassandra added
duration
type in 3.10https://issues.apache.org/jira/browse/CASSANDRA-13174
The text was updated successfully, but these errors were encountered: