Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Filtering on counter columns doesn't work (works in Cassandra 3.0) #5635

Closed
nyh opened this issue Jan 23, 2020 · 1 comment · Fixed by #6277
Closed

Filtering on counter columns doesn't work (works in Cassandra 3.0) #5635

nyh opened this issue Jan 23, 2020 · 1 comment · Fixed by #6277
Assignees
@jul-stas
Labels
area/cassandra 3.x compatibility area/counters CQL feature user request
Milestone
4.1

Comments

@nyh
Copy link
Contributor

nyh commented Jan 23, 2020

A user reported on stack-overflow https://stackoverflow.com/questions/59859080/filter-condition-not-working-on-counter-columns-in-scylladb-where-it-works-in-ca:

Filter condition not working on counter columns in ScyllaDB where it works in Cassandra 3.0

I have a use case where I am using filters on counter columns in cassandra. Now I am migrating to Scylla, and I see that scylla won't support counter column filters.
@jul-stas jul-stas self-assigned this Jan 24, 2020
@slivne slivne added this to the 3.4 milestone Jan 26, 2020
@slivne slivne modified the milestones: 4.0, 4.1 Apr 15, 2020
@jul-stas jul-stas mentioned this issue Apr 23, 2020
Merged
avikivity pushed a commit that referenced this issue Aug 27, 2020
@psarna @avikivity
Merge 'counters: Fix filtering of counters' from Juliusz
f258e6f 
Queries with `ALLOW FILTERING` and constraints on counter
values used to be rejected as "unimplemented". The reason
was a missing tri-comparator, which is added in this patch.

Fixes #5635

* jul-stas-5635-filtering-on-counters:
  cql/tests: Added test for filtering on counter columns
  counters: add comparator and remove `unimplemented` from restrictions

(cherry picked from commit c32faee)
@avikivity
Copy link
Member

Backported to 4.0 (4.1+ are safe).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jul-stas jul-stas

Labels
area/cassandra 3.x compatibility area/counters CQL feature user request
Projects
None yet
Milestone
4.1
Development

Successfully merging a pull request may close this issue.

counters: Fix filtering of counters jul-stas/scylladb
5 participants
@nyh @avikivity @slivne @scylladb-promoter @jul-stas