Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

node_exporter_install --force failing #6782

Closed
dyasny opened this issue Jul 7, 2020 · 1 comment
Closed

node_exporter_install --force failing #6782

dyasny opened this issue Jul 7, 2020 · 1 comment
Milestone
4.3

Comments

@dyasny
Copy link
Contributor

dyasny commented Jul 7, 2020

Installation details
Scylla version (or git commit hash): 4.1.1-0.20200703.1d9bbbc9577
Cluster size:
OS (RHEL/CentOS/Ubuntu/AWS AMI): CentOS7

Hardware details (for performance issues) Delete if unneeded
Platform (physical/VM/cloud instance type/docker): t3.large

[centos@ip-10-1-56-33 ~]$ sudo node_exporter_install --force
node_exporter already installed, reinstalling
Traceback (most recent call last):
  File "/opt/scylladb/scripts/libexec/node_exporter_install", line 62, in <module>
    tf.extractall(INSTALL_DIR)
  File "/opt/scylladb/python3/lib64/python3.7/tarfile.py", line 2000, in extractall
    numeric_owner=numeric_owner)
  File "/opt/scylladb/python3/lib64/python3.7/tarfile.py", line 2042, in extract
    numeric_owner=numeric_owner)
  File "/opt/scylladb/python3/lib64/python3.7/tarfile.py", line 2112, in _extract_member
    self.makefile(tarinfo, targetpath)
  File "/opt/scylladb/python3/lib64/python3.7/tarfile.py", line 2153, in makefile
    with bltn_open(targetpath, "wb") as target:
OSError: [Errno 26] Text file busy: '/opt/scylladb/Prometheus/node_exporter/node_exporter-0.17.0.linux-amd64/node_exporter'

The script should be able to deal with node_exporter already running and holding the file open
syuu1228 added a commit to syuu1228/scylla that referenced this issue Jul 7, 2020
@syuu1228
node_exporter_install: stop service before force installing
e910747 
Stop node-exporter.service before re-install it, to avoid 'Text file busy' error.

Fixes scylladb#6782
@syuu1228 syuu1228 mentioned this issue Jul 7, 2020
Merged
avikivity pushed a commit that referenced this issue Jul 7, 2020
@syuu1228 @avikivity
node_exporter_install: stop service before force installing
76a312a 
Stop node-exporter.service before re-install it, to avoid 'Text file busy' error.

Fixes #6782
@tzach tzach added this to the 4.3 milestone Nov 16, 2020
@avikivity
Copy link
Member

Backported to 4.2, 4.1 (already present on 4.3).

avikivity pushed a commit that referenced this issue Dec 15, 2020
@syuu1228 @avikivity
node_exporter_install: stop service before force installing
f7ffea4 
Stop node-exporter.service before re-install it, to avoid 'Text file busy' error.

Fixes #6782

(cherry picked from commit ef05ea8)
avikivity pushed a commit that referenced this issue Dec 15, 2020
@syuu1228 @avikivity
node_exporter_install: stop service before force installing
d0530d8 
Stop node-exporter.service before re-install it, to avoid 'Text file busy' error.

Fixes #6782

(cherry picked from commit ef05ea8)
asias pushed a commit to asias/scylla that referenced this issue Apr 15, 2021
@syuu1228 @avikivity
node_exporter_install: stop service before force installing
b5499c0 
Stop node-exporter.service before re-install it, to avoid 'Text file busy' error.

Fixes scylladb#6782

(cherry picked from commit ef05ea8)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
4.3
Development

No branches or pull requests
4 participants
@tzach @dyasny @avikivity @scylladb-promoter