New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
thrift: backport thrift >= 0.11 support from #4538 to 3.1 #5190
thrift: backport thrift >= 0.11 support from #4538 to 3.1 #5190
Conversation
The upstream commit is 98bc9ed. It does not @avikivity This does not fit into the typical definition of fixing a regression or a critical bug so I am leaving the decision for you. @ultrabug Could you elaborate on why you need this? That is, what specifically are you blocked on by this? |
Hi @penberg I think this is too late for this PR to get in since 3.2 is around the corner and includes this patch (hopefully?). Thing is that I get to maintain and backport this patch myself on the Gentoo ebuild side if it's not included by the release so it's something I'd like to keep to a minimum. With your approval, I'd like to close this PR. |
I think we can include compatibility with upstream libraries as bug fixes, even though our own packages use a frozen toolchain and don't suffer from such problems (i.e. we shouldn't privilege our delivery method) |
Dequeueing; fails with
(using dbuild) |
I'd like to backport #4538 to 3.1 please 馃憤
Tested OK here.