Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get rid of handle_state_replacing #12330

Closed
kbr-scylla opened this issue Dec 15, 2022 · 2 comments · Fixed by #12349
Closed

Get rid of handle_state_replacing #12330

kbr-scylla opened this issue Dec 15, 2022 · 2 comments · Fixed by #12349
Milestone

Comments

@kbr-scylla
Copy link
Contributor

Since 2ec1f71 nodes no longer publish HIBERNATE state. This commit ended up in Scylla 4.6.

However, the old code for handling HIBERNATE state is still there:

        } else if (move_name == sstring(versioned_value::HIBERNATE)) {
            co_await handle_state_replacing(endpoint);

We could remove this and replace it with an ERROR message if a node publishes HIBERNATE - that is indeed an error, since it would mean we're doing replace in a mixed cluster - and with a <=4.5 node replacing one of our nodes (which would probably fail earlier anyway since the node would not pass feature check).

@kbr-scylla
Copy link
Contributor Author

The commit is also present in scylla enterprise 2022.1.0
https://github.com/scylladb/scylla-enterprise/commit/2ec1f719de29d98e1be7fc7c171b06986b81af14

I think we can also assume that e.g. 2021.X nodes don't try to replace >=5.2 nodes (which should also fail due to a feature check)

@kbr-scylla
Copy link
Contributor Author

Documentation must also be updated: docs/operating-scylla/procedures/cluster-management/replace-dead-node.rst mentions that the replacing node goes through hibernate state, which is wrong.

@kbr-scylla kbr-scylla added the documentation Requires documentation label Dec 15, 2022
@DoronArazii DoronArazii added this to the 5.2 milestone May 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants