Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

throwing reader_concurrency_semaphore::consume() causes memory leaks #12767

Closed
denesb opened this issue Feb 7, 2023 · 1 comment · Fixed by #12756
Closed

throwing reader_concurrency_semaphore::consume() causes memory leaks #12767

denesb opened this issue Feb 7, 2023 · 1 comment · Fixed by #12756
Assignees
Labels
Milestone

Comments

@denesb
Copy link
Contributor

denesb commented Feb 7, 2023

Said method can now throw std::bad_alloc since aab5954. All call-sites should have been adapted in the series introducing the throw, but some managed to slip through because the oom unit test didn't run in debug mode.
In particular, the mutation_fragment constructors (which call consume()) and the tracking allocator are vulnerable.

@avikivity
Copy link
Member

No vulnerable branches, not backporting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants