Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stream_session does not ignore no_such_column_family exceptions #15257

Open
bhalevy opened this issue Sep 3, 2023 · 6 comments
Open

stream_session does not ignore no_such_column_family exceptions #15257

bhalevy opened this issue Sep 3, 2023 · 6 comments
Assignees
Labels
area/streaming P2 High Priority triage/master Looking for assignee

Comments

@bhalevy
Copy link
Member

bhalevy commented Sep 3, 2023

As noted in #13045 (comment)

There are also a few places in streaming that need to ignore dropped tables:

, _cf(_db.local().find_column_family(_id))

auto op = _db.local().find_column_family(cf_id).stream_in_progress();

db.find_column_family(ks, cf);

db.find_column_family(cf_id);

@mykaul
Copy link
Contributor

mykaul commented Sep 4, 2023

@asias - who should handle this? What's the priority?

@asias
Copy link
Contributor

asias commented Sep 5, 2023

@asias - who should handle this? What's the priority?

I took a look at all the call sites. It is not that complicated. It sounds like a good candidate to let @piodul get familiar with the streaming code. @eliransin FYI.

@DoronArazii DoronArazii added the P2 High Priority label Sep 6, 2023
@mykaul
Copy link
Contributor

mykaul commented Dec 24, 2023

@denesb - please prioritize / assign (or de-prioritize)

@avikivity
Copy link
Member

Please don't use images in issues for text, they're unsearchable.

@mykaul
Copy link
Contributor

mykaul commented Dec 24, 2023

Please don't use images in issues for text, they're unsearchable.

These are not images - but actually GH hyperlinks - that for some reason may not be searchable?

@avikivity
Copy link
Member

Please don't use images in issues for text, they're unsearchable.

These are not images - but actually GH hyperlinks - that for some reason may not be searchable?

My mistake, it looked like an image to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/streaming P2 High Priority triage/master Looking for assignee
Projects
None yet
Development

No branches or pull requests

7 participants