Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tablets: alter keyspace - loosen rejection criteria #19127

Open
Tracked by #19123
ptrsmrn opened this issue Jun 5, 2024 · 0 comments
Open
Tracked by #19123

tablets: alter keyspace - loosen rejection criteria #19127

ptrsmrn opened this issue Jun 5, 2024 · 0 comments

Comments

@ptrsmrn
Copy link
Contributor

ptrsmrn commented Jun 5, 2024

Currently ALTERing is not possible if there's any other global topology request ongoing, but we should reconsider this restriction per #16723 (comment):

It's simpler to first restrict the conflicts by scope (keyspace) rather than by type.
Then, we can consider higher grain resolution by type within the keyspace.
Right now it would be acceptable to fail rf change if there's any other admin operation on the keyspace, like another rf-change, or even repair. As for tablet migration, we should serialize them with rf changes, but alter ks shouldn't fail if there are migrations going on in the background, but rather it should serialize with them.
It is questionable whether rf change should fail if there is a potentially long running node operation ongoing, like decommission or remove node. If we can detect them I think it would be better to fail rf changes until they're done.

@ptrsmrn ptrsmrn added this to the 6.1 milestone Jun 5, 2024
@ptrsmrn ptrsmrn self-assigned this Jun 5, 2024
@ptrsmrn ptrsmrn modified the milestones: 6.1, 6.2 Jul 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant