New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dist/docker/debian/README.md is wrong #9263
Comments
@nyh Thanks for openning the issue, i will send a patch soon |
@yaronkaikov please note that I assigned this to myself because I almost have a patch for it myself - I'm just missing a solution for step 4. Can you please try it yourself and see what is the correct step 4? |
As @avikivity noted on the mailing list, step 4 became outdated with commit e96ff3d. As that commit suggests that the output of step 3 is just a file, which "can be uploaded into a repository or made available locally with skopeo.". Now I just need to figure out what this sentence means, and how to explain it in the document. |
@nyh it's my fault for not supplying a good README, I can send something. |
If you can even write a few lines, I'll complete the text and test it. Right have a file |
@avikivity I couldn't figure out how to use skopeo to run such an archive in docker, or how to run it directly in docker. It seems podman supports it out-of-the-box, though:
Seems to work. Do you know to run it in docker instead of podman? |
I haven't run docker in a while, I expect |
@nyh Same command with |
It doesn't work for me - it tells me "docker: invalid reference format.". It works well in podman. My docker version is 20.10.7. |
So it's not working for me either (docker command was an alias for podman). Since we are using |
Developer documentation, so not backporting. |
Almost all steps in the instructions in
dist/docker/debian/README.md
are wrong or misleading:Step 2 is wrong because it builds all modes again. Should be "dist-dev" (which unfortunately not only builds the deb target, but at least doesn't build all modes! at least not after I sent a patch to fix a bug in that area).
Step 3 is missing "--mode dev" (so uses release mode by default).
Step 4 assumes there is a Dockerfile in the Scylla main source directory, but there isn't. Step 4 probably needs to be replaced by entirely different command, but I can't yet figure out by what and need help.
The text was updated successfully, but these errors were encountered: