Added options for searching anime by season on kitsu #44
Conversation
# Conflicts: # anipy_cli/cli.py # anipy_cli/download.py # requirements.txt
…nloads to start in bulk after episode selection
…nloads to start in bulk after episode selection
# Conflicts: # anipy_cli/__init__.py # anipy_cli/cli.py
| """ | ||
|
|
||
| assert ( | ||
| season_name in self.season_names |
There was a problem hiding this comment.
we could use the .lower() method here to prevent the only lower case
There was a problem hiding this comment.
didn't think about that, but true :D
|
Okay, this is pretty cool though two things before merging, could you add the extra dependencies to setup.py, and add a option in the config to deactivate the prompt, some users may not want to always type no if they don't want to search the seasons. Other than that, I tested it and it works. |
|
lgtm, thanks for the pr! |
|
Lol that was quick haha ^^ |
|
Also the kitsu api library needs at least python 3.9 if I am not mistaken. Should we add that to readme? |
|
I added it to the install procedure so it will enforce it automatically |
|
|
|
Oh nevermind, you already did that I will include that version in this script, that okay for you? |
|
Oh yea regarding that, I submitted a PR to MrArkon/kitsu.py, but it hasn't been approved and merged yet. Alternatively I could make some changes to the AnimeInfo class, so it works with the version of kitsu.py that is currently available on pypi. |
|
Yeah I just noticed that. Lets do that, the maintainer doesn't seem to be active, so that's probably the only option. |
Added options for searching anime by season on kitsu
I wanted to have the option to display and select anime by year and season, so the following was implemented: