Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Multi Threaded m3u8 Download and added check if file exists before DL #49

Merged
merged 11 commits into from Apr 21, 2022

Conversation

dymattic
Copy link
Contributor

@dymattic dymattic commented Apr 21, 2022

made quite some changes to the multi threaded downloading of m3u8 playlists.
Heavily inspired by this project.

Requires ffmpeg for mergin downloaded parts now.

@dymattic dymattic closed this Apr 21, 2022
@dymattic
Copy link
Contributor Author

Downloaded files without audio, needs more work

@dymattic dymattic reopened this Apr 21, 2022
@dymattic
Copy link
Contributor Author

OK Multi threaded m3u8 DLs work with audio and correct qualit now :D

@sdaqo
Copy link
Owner

sdaqo commented Apr 21, 2022

@dymattic can we avoid using ffmpeg to merge the files, since it is an external program? I guess you used it for merging audio and video? How about we try someting like this its a python libary not using external programs.

@dymattic
Copy link
Contributor Author

@dymattic can we avoid using ffmpeg to merge the files, since it is an external program? I guess you used it for merging audio and video? How about we try someting like this its a python libary not using external programs.

Yea you're right about that.
Isn't the ffmpeg method I use also a python library? Or is it just a wrapper for ffmpeg?

@sdaqo
Copy link
Owner

sdaqo commented Apr 21, 2022

yea you're right about that.
Isn't the ffmpeg method I use also a python library? Or is it just a wrapper for ffmpeg?

Its just a wrapper and executes a process.
And the libary what I pointed out also uses ffmpeg, I got that wrong, but it installs it automatically, this is what it says on their page:

MoviePy depends on the software FFMPEG for video reading and writing. You don’t need to worry about that, as FFMPEG should be automatically downloaded/installed by ImageIO during your first use of MoviePy (it takes a few seconds). If you want to use a specific version of FFMPEG, you can set the FFMPEG_BINARY environment variable See moviepy/config_defaults.py for details.

I think we should prefer this methode over using the ffmpeg lib.

@dymattic
Copy link
Contributor Author

yea you're right about that.
Isn't the ffmpeg method I use also a python library? Or is it just a wrapper for ffmpeg?

Its just a wrapper and executes a process. And the libary what I pointed out also uses ffmpeg, I got that wrong, but it installs it automatically, this is what it says on their page:

MoviePy depends on the software FFMPEG for video reading and writing. You don’t need to worry about that, as FFMPEG should be automatically downloaded/installed by ImageIO during your first use of MoviePy (it takes a few seconds). If you want to use a specific version of FFMPEG, you can set the FFMPEG_BINARY environment variable See moviepy/config_defaults.py for details.

I think we should prefer this methode over using the ffmpeg lib.

You are right, switched to using ffmpeg via moviepy now 👍

@sdaqo
Copy link
Owner

sdaqo commented Apr 21, 2022

Ok, nice! Thanks for the PR.

@sdaqo sdaqo merged commit 516ed29 into sdaqo:master Apr 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants