Audio cuts out if tone stack is activated before loading certain models

[sdatkinson]

A user reports:

profile loader bug. You can load a few profiles, but sometimes a profile that you load disables the plugins audio. You have to close it and reopen the plugin. Live 11.2, Mac M1, Ventura

[sdatkinson]

Additional info:

Using AU. I can try VST3 to see if that works better. For instance, your REVV Purple doesnt work, but the REVV Red profile works. Some profiles load, some dont. The output of the plugin disables, however, the input of the plugin shows activity.

[sdatkinson]

I'm seeing this as well on my Mac. I'll have to do some digging.

[sdatkinson]

Notes after digging:

• It isn't specific to standalone or VST3.
• Opening purple immediately causes a cut-out.
• Opening my "5150" model makes it fine to load the purple next.
• If I load the purple in the VST (causing a cutout) within Reaper, then save the project, close Reaper, and re-load, it comes up fine.

It seems there's something odd about loading that model that doesn't happen when re-starting the plugin, which is interesting.

I've been checking using version 0.6.0, but I'm keen to know if this is a problem in 0.5.8 as well or if it's new.

[sdatkinson]

Bug seems to have been introduced in 3e204dc (#30), works on c6a9c0d (#29).

Confirmed that it seems to go away if I bypass the EQ and hook up the output of the amp to the IR.

Very strange though that it seems to depend on the model that's loaded. My guess is that it really is a problem in the model, and there's something that's walking over the EQ objects.

One potential cleanup would be to switch over to using std::vectors inside the plugin instead of raw pointers.

[sdatkinson]

I'm almost certain that the issue lies with WaveNet models with Layer arrays that start with a dilation other than 1 (both Revvs as well as other models I've trained with the same architecture all seem to be the common thread). Hopefully that'll yield the key!

[sdatkinson]

Update issue name following partial resolution with #46. If Mac users just don't use the tone stack, then they should be ok! 😅

[sdatkinson]

Resolved by #76