Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ClearSiteDataMiddleware #74

Merged
merged 2 commits into from Aug 22, 2019
Merged

Add ClearSiteDataMiddleware #74

merged 2 commits into from Aug 22, 2019

Conversation

Gee19
Copy link
Member

@Gee19 Gee19 commented Aug 19, 2019

Add a ClearSiteDataMiddleware and respective django settings.

CLEAR_SITE_DATA_URL_WHITELIST - whitelist of URLs that Clear-Site-Data response header is applied to (eg. /accounts/logout/)
CLEAR_SITE_DATA_DIRECTIVES - what directives to apply (defaults to wildcard)

https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Clear-Site-Data

@Gee19 Gee19 force-pushed the feature/clear_site_data branch 2 times, most recently from f496aca to 43309bb Compare August 20, 2019 08:32
@Gee19 Gee19 changed the title WIP: Add ClearSiteDataMiddleware Add ClearSiteDataMiddleware Aug 20, 2019
@RouganStriker
Copy link
Member

I think there is a doc or README we need to update to document the new middlewre

@Gee19
Copy link
Member Author

Gee19 commented Aug 22, 2019

I think there is a doc or README we need to update to document the new middlewre

Looks like docs are autogenerated based on index.rst

@lmontopo
Copy link

This MR and the other look good to me. I haven't tested it, but I can if you'd like me to. CR +1.

@RouganStriker
Copy link
Member

I think there is a doc or README we need to update to document the new middlewre

Looks like docs are autogenerated based on index.rst

I don't think the README file gets auto-updated though; I just remember having to manually update that every time I modify a middleware.

@Gee19
Copy link
Member Author

Gee19 commented Aug 22, 2019

@RouganStriker Oh right! Good call I forgot about the list of middlewares there

Refs #SDE-7177
@lmontopo
Copy link

+1.

@Gee19 Gee19 merged commit 84db57b into master Aug 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants