Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug Report: Checkmarks for Modules Enabled Displayed Incorrectly #98

Closed
GorgoPrimus opened this issue Jun 25, 2023 · 8 comments
Closed

Comments

@GorgoPrimus
Copy link

When this module is on, the Manage Module menu shows checkmarks for which module is enabled in the middle of module names instead of in the check boxes - which looks awful and makes it harder to much read the ui.

@karpana
Copy link

karpana commented Jul 19, 2023

Adding some additional context, as I noticed the same thing on my installation.

This behaviour was not present in v10
it seems to be introduced in v11, even when Tidy UI is the only module running.

@karpana
Copy link

karpana commented Jul 19, 2023

took a look (in google debug screens) as to what might be causing the issue with the checkmarks moving away from the box.

in the tidy-ui_game-settings.css file there is the following code block

#module-management input[type="checkbox"]:checked::after {
  content: "";
  display: block;
  background: url(../img/check-solid.svg) center no-repeat;
  background-size: cover;
  position: absolute;
  width: 16px;
  height: 16px;
  top: 50%;
  left: 50%;
  transform: translate(-50%, -50%);
}

Changing the left: 50%; to left: 2%; moves the checkbark roughly back to where it needs to be.

this is a far from elegant solution, and probably has more to do with some of the UI changes in v11 than anything else. But as a quick fix to make this appear less broken, you might find value in this temporary approach.

@King-Wedgie
Copy link
Contributor

Following this, I was able to fix it by just deleting the top and left lines and adjusting transform: translate(-50%, -50%); to transform: translate(5%, 5%);

Adjusted code block:

#module-management input[type="checkbox"]:checked::after {
  content: "";
  display: block;
  background: url(../img/check-solid.svg) center no-repeat;
  background-size: cover;
  position: absolute;
  width: 16px;
  height: 16px;
  transform: translate(5%, 5%);
}

@GorgoPrimus
Copy link
Author

Is the author not working on this anymore, or are they maybe just waiting for someone to make a Pull Request with that?

@King-Wedgie
Copy link
Contributor

Made the pull request (first one ever, yay!), will have to wait and see if @sdenec is still maintaining this.

@GorgoPrimus
Copy link
Author

Good luck! In the meantime, at least we can manually edit in a solution thanks to you. :)

@sdenec sdenec closed this as completed Sep 15, 2023
@GorgoPrimus
Copy link
Author

Yay! Thanks sdenec!

@sdenec
Copy link
Owner

sdenec commented Sep 15, 2023

No, thank you! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants