Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix zsh completion #164

Merged
merged 2 commits into from Aug 2, 2022
Merged

Fix zsh completion #164

merged 2 commits into from Aug 2, 2022

Conversation

ad-chaos
Copy link
Contributor

Before we were implicitly declaring the opts and coms arrays, which had the undesired effect of zsh parsing it as an associative array instead of a normal array.

Now we explicitly declare the opts and coms arrays to be normal arrays.

@ad-chaos ad-chaos marked this pull request as draft June 17, 2022 07:25
@ad-chaos
Copy link
Contributor Author

As an aside it would be nice to test whether the completions are working or not.

One way I couls think of doing it would be via running the _complete_debug widget and checking if there are no error messages in it.

@ad-chaos ad-chaos marked this pull request as ready for review June 17, 2022 08:05
@Secrus
Copy link
Member

Secrus commented Jul 13, 2022

Did you test those changes manually?

@ad-chaos
Copy link
Contributor Author

You mean?

@Secrus
Copy link
Member

Secrus commented Jul 28, 2022

I meant, did you install these completions locally and tested that they work properly?

@ad-chaos
Copy link
Contributor Author

ad-chaos commented Aug 2, 2022

Yes I did. You can try it yourself with the example in the readme :)

@Secrus Secrus merged commit c12b776 into python-poetry:master Aug 2, 2022
@ad-chaos ad-chaos deleted the zsh_completions branch August 26, 2022 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants