Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

get_attribute to consider fillable attributes #390

Open
wants to merge 1 commit into
base: 0.9
Choose a base branch
from

Conversation

pmn4
Copy link

@pmn4 pmn4 commented Feb 5, 2021

Hey @sdispater, not sure whether you accept outside PRs, but would you consider attributes defined in the __fillable__ array to be honored by the get_attribute method?

class Person(Model):
  __fillable__ = ['name']

person = Person()

print(person.name) # expect None, get AttributeError

(I am fairly new to Python and was not able to run the test suite, so while it looks like my tests should work, I wasn't actually able to run them)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant