Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pendulum.now() type hint doesn't allow datetime.timezone #783

Open
gwerbin opened this issue Dec 18, 2023 · 0 comments
Open

pendulum.now() type hint doesn't allow datetime.timezone #783

gwerbin opened this issue Dec 18, 2023 · 0 comments

Comments

@gwerbin
Copy link

gwerbin commented Dec 18, 2023

The type hint for pendulum.now doesn't permit datetime.timezone a valid input, even though it appears to be valid for the underlying DateTime.now function:

def now(tz: str | Timezone | None = None) -> DateTime:

def now(
cls, tz: str | Timezone | FixedTimezone | datetime.tzinfo | None = None
) -> Self:

Is this deliberate, or an oversight?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant