Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix warnings with Python 3.7 #489

Merged
merged 3 commits into from Oct 15, 2018
Merged

Fix warnings with Python 3.7 #489

merged 3 commits into from Oct 15, 2018

Conversation

dmerejkowsky
Copy link
Contributor

Before:

$ pytest
src/poetry/poetry/utils/appdirs.py:92: DeprecationWarning: invalid escape sequence \D
  """
src/poetry/poetry/utils/appdirs.py:154: DeprecationWarning: invalid escape sequence \D
  """
...
322 passed, 42 warnings in 8.24 seconds

After:

$ pytest
...
322 passed, 2 warnings in 5.08 seconds

Note: the remaining 2 warnings are coming from jsonschema and html5lib, we can probably ignore them for now. (Maybe I'll open an issue upstream)

Cheers!

@dmerejkowsky
Copy link
Contributor Author

dmerejkowsky commented Oct 11, 2018

By the way, would you be willing to accept a PR adding support for Python3.7 to the CI ?

Update: I've done it already :)

@sdispater sdispater merged commit 395346d into python-poetry:master Oct 15, 2018
@sdispater
Copy link
Member

Thanks!

@dmerejkowsky dmerejkowsky deleted the 3.7 branch October 16, 2018 09:08
Copy link

github-actions bot commented Mar 1, 2024

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants