Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: type annotation of unwrap() and datetime parsing #229

Merged
merged 1 commit into from
Aug 13, 2022
Merged

fix: type annotation of unwrap() and datetime parsing #229

merged 1 commit into from
Aug 13, 2022

Conversation

achimnol
Copy link
Contributor

@achimnol achimnol commented Aug 13, 2022 •
edited
Loading

When using tomlkit in type-annotated projects, some unwrap() methods have wrong return-type signatures.
Also running mypy in the current source tree reports many errors; this PR tries to fix some low-hanging fruits by introducing type-narrowing with assert isinstance(...).

@frostming frostming merged commit 80f958c into python-poetry:master Aug 13, 2022
@achimnol achimnol deleted the fix/type-anno-unwrap branch August 13, 2022 15:07
@frostming frostming mentioned this pull request Sep 27, 2022
Merged
capuanob pushed a commit to capuanob/tomlkit that referenced this pull request Mar 1, 2023
@achimnol
fix: type annotation of unwrap() and datetime parsing (python-poetry#229
1d4aed9 
)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@achimnol @frostming