Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added configurable TwelveHourDateTimeConverter #20

Merged
merged 6 commits into from
May 20, 2018
Merged

Conversation

awj100
Copy link
Contributor

@awj100 awj100 commented May 18, 2018

Implemented a custom DateTime converter which uses a default format string, though this can be overridden with an environment variable which corresponds to the date formatting on the GroupShare server.

This version also upgrades the project/assembly from .NET Standard 1.3 to .NET Standard 2.0 - this was required to retrieve an environment variable from the correct target environment ("User").

…m date format for MultiTerm termbases. If not present in env vars then a default (using US M/dd/yyyy format) is used.

Also updated to .NETStandard 2.0.
@cromica
Copy link
Collaborator

cromica commented May 18, 2018

We have an open defect in GroupShare for this also. We might be able to fix it in CU8.

@cromica
Copy link
Collaborator

cromica commented May 20, 2018

Accepting this as there are some issues with the build infrastructure

@cromica cromica merged commit 7dd6e7f into RWS:master May 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants