Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

braces for the first css selectors #75

Closed
RolandNaijuka opened this issue Sep 24, 2019 · 3 comments
Closed

braces for the first css selectors #75

RolandNaijuka opened this issue Sep 24, 2019 · 3 comments

Comments

@RolandNaijuka
Copy link

The braces for the first selector in the created CSS code creates the closing braces at the end of the file instead of closing that first selector

@pnevares
Copy link
Contributor

I had noticed this but immediately recognized it as Sass/Less-style nested selectors. But I also understand that it's not accessible to anybody unfamiliar with those tools. Intentional or not I agree that this behavior should change.

@wlvstv
Copy link
Contributor

wlvstv commented Oct 2, 2019

@RolandNaijuka / @pnevares is the issue that you are seeing the div classes nested within the parent like so?

.parent {
  display: grid;
  grid-template-columns: repeat(5, 1fr);
  grid-template-rows: repeat(5, 1fr);
  grid-column-gap: 0px;
  grid-row-gap: 0px;
  .div1 { grid-area: 1 / 1 / 4 / 5; }
  .div2 { grid-area: 2 / 5 / 3 / 6; }
  .div3 { grid-area: 2 / 5 / 4 / 6; }
} 

are you preferring to see a closed parent with subsequent div line items? like this:

.parent {
  display: grid;
  grid-template-columns: repeat(5, 1fr);
  grid-template-rows: repeat(5, 1fr);
  grid-column-gap: 0px;
  grid-row-gap: 0px;
}
.div1 { grid-area: 1 / 1 / 4 / 5; }
.div2 { grid-area: 2 / 5 / 3 / 6; }
.div3 { grid-area: 2 / 5 / 4 / 6; }

@sdras
Copy link
Owner

sdras commented Oct 3, 2019

Correct, this is SCSS syntax. If you've never tried it, you should check it out. Updated.

@sdras sdras closed this as completed Oct 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants