Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Too much italic #202

Open
sdras opened this issue Apr 24, 2019 · 4 comments
Open

Too much italic #202

sdras opened this issue Apr 24, 2019 · 4 comments

Comments

@sdras
Copy link
Owner

sdras commented Apr 24, 2019

Every time I work in a Vuex file, this annoys me. I need to reduce some of the italic in this theme, it's too heavy.

@alinnert
Copy link

I think it's not only the amount. Some themes make keywords in general italic, but currently some keywords are missing italics in Night Owl (function, const, if, switch, etc.). What do you think?

@zellwk
Copy link

zellwk commented Feb 18, 2020

@sdras Happy to help with this. I have a proposition about reducing italics. What's the best way to communicate them with you? Send a PR + demo pictures?

I could potentially list out the things I wish to change, then get back to you for approval? 🤔 . Let me know what works best.

What I've done so far:

before

after

@sdras
Copy link
Owner Author

sdras commented Feb 18, 2020

Thanks for writing in! Unfortunately that's not the direction I want to take it. I use the italics to balance contrast for things that are similarly colored and so need another distinction (i.e. the teal and the blue, not the purple). It's not really arbitrary, I spend a long time looking through all the languages to see the impacts. If you want to try again, that's more of what I'm looking for but I wouldn't blame you if you don't want to try to sort things out based on my needs here :)

@zellwk
Copy link

zellwk commented Feb 18, 2020

@sdras I get what you're saying. Happy to help if I knew what you were thinking about. Maybe something closer to this?

CleanShot 2020-02-18 at 19 49 57@2x

This is my code though. I'm happy to look at js.js and vuedemo.vue and see what I can improve. But a better way would be you taking a screenshot or video and talk through what you wanna change :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants