Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing scope in italics config? #26

Closed
jcmrva opened this issue May 19, 2018 · 5 comments
Closed

Missing scope in italics config? #26

jcmrva opened this issue May 19, 2018 · 5 comments
Labels
good first issue Good for newcomers

Comments

@jcmrva
Copy link

jcmrva commented May 19, 2018

I copy/pasted from the readme and I still get a few:

image

It's not particularly bothersome here, just thought I'd point it out.

@sdras
Copy link
Owner

sdras commented May 19, 2018

Thank you for pointing this out! I actually adjusted a few things after putting that in the readme, you're absolutely right that I need to revisit those settings.

@dustinmartin
Copy link

I did some googling for this issue and found this snippet on Stackoverflow: https://stackoverflow.com/a/49202435
Quite verbose but does the trick.

Great work on the theme!

@sdras sdras added the good first issue Good for newcomers label May 23, 2018
@sdras
Copy link
Owner

sdras commented May 24, 2018

Ok this should be fixed! It shouldn't have been italic. Feel free to reopen if you see anything funny after I close it.

@sdras sdras closed this as completed May 24, 2018
@sdras
Copy link
Owner

sdras commented May 27, 2018

I now have a no italics version of this theme! If you reload the extension, you'll see it and be able to use it :)

@jcmrva
Copy link
Author

jcmrva commented May 27, 2018

That took care of it, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants