New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Option for changing color of the Rotating texts #9 #29
Conversation
Hi @Anu-123-gif , Thanks for your contribution! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Your present implementation of the feature is working, but I think the code can be improved in order to prevent any errors when other developers are using the library. Take a look at the changes I have requested.
I really appreciate your efforts.
Happy Coding!
app/src/main/java/com/sdsmdg/harjot/rotatingtextlibrary/MainActivity.java
Outdated
Show resolved
Hide resolved
rotatingtext/src/main/java/com/sdsmdg/harjot/rotatingtext/RotatingTextSwitcher.java
Outdated
Show resolved
Hide resolved
rotatingtext/src/main/java/com/sdsmdg/harjot/rotatingtext/models/Rotatable.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Make the reviewed changes.
rotatingtext/src/main/java/com/sdsmdg/harjot/rotatingtext/models/Rotatable.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job with the changes! Kindly reply to the suggestion I have made.
rotatingtext/src/main/java/com/sdsmdg/harjot/rotatingtext/models/Rotatable.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good Job @Anu-123-gif . @dev-ritik need your feedback on the code before we can merge it. I have tested it, its working fine.
rotatingtext/src/main/java/com/sdsmdg/harjot/rotatingtext/RotatingTextSwitcher.java
Outdated
Show resolved
Hide resolved
rotatingtext/src/main/java/com/sdsmdg/harjot/rotatingtext/RotatingTextSwitcher.java
Outdated
Show resolved
Hide resolved
rotatingtext/src/main/java/com/sdsmdg/harjot/rotatingtext/RotatingTextSwitcher.java
Outdated
Show resolved
Hide resolved
rotatingtext/src/main/java/com/sdsmdg/harjot/rotatingtext/RotatingTextSwitcher.java
Outdated
Show resolved
Hide resolved
rotatingtext/src/main/java/com/sdsmdg/harjot/rotatingtext/RotatingTextWrapper.java
Outdated
Show resolved
Hide resolved
rotatingtext/src/main/java/com/sdsmdg/harjot/rotatingtext/RotatingTextWrapper.java
Outdated
Show resolved
Hide resolved
rotatingtext/src/main/java/com/sdsmdg/harjot/rotatingtext/models/Rotatable.java
Outdated
Show resolved
Hide resolved
LGTM! 🎉 |
@Anu-123-gif Resolve these conflicts, and we are good to go. You can resolve in the web editor quickly but its recommended that you do it via terminal. |
@dev-ritik I have resolved conflicts , thanks ! |
An array of integers representing colors chosen by the user is added to a rotatable and the words are displayed accordingly.
Please review my code @CoderMayhem