Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support SJD in ImageNamer #26

Merged
merged 3 commits into from Apr 25, 2022
Merged

Support SJD in ImageNamer #26

merged 3 commits into from Apr 25, 2022

Conversation

albireox
Copy link
Member

ImageNamer now supports adding an SJD as part of the dirname.

@codecov
Copy link

codecov bot commented Apr 25, 2022

Codecov Report

Merging #26 (f5ba735) into main (a5e45f1) will decrease coverage by 0.39%.
The diff coverage is 50.00%.

@@            Coverage Diff             @@
##             main      #26      +/-   ##
==========================================
- Coverage   94.14%   93.76%   -0.38%     
==========================================
  Files          21       21              
  Lines        1365     1377      +12     
  Branches      263      265       +2     
==========================================
+ Hits         1285     1291       +6     
- Misses         48       53       +5     
- Partials       32       33       +1     
Impacted Files Coverage Δ
basecam/models/fits.py 95.84% <ø> (ø)
basecam/exposure.py 89.86% <47.37%> (-3.84%) ⬇️
basecam/actor/commands/expose.py 91.58% <100.00%> (+0.09%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ef6bebb...f5ba735. Read the comment docs.

@albireox albireox merged commit ba0b1fb into main Apr 25, 2022
@albireox albireox deleted the allow-sjd branch April 25, 2022 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant