Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

numpy release constraint in pyproject.toml #31

Open
rmathar opened this issue Dec 13, 2022 · 3 comments
Open

numpy release constraint in pyproject.toml #31

rmathar opened this issue Dec 13, 2022 · 3 comments
Assignees

Comments

@rmathar
Copy link

rmathar commented Dec 13, 2022

The specification of numpy <1.22.0 in pyproject.toml is too restrictive. In LVMT we are currently using 1.23.5 .
Obviously the pip installer cannot resolve such incompatible requirements.

@albireox albireox self-assigned this Dec 13, 2022
@albireox
Copy link
Member

I'll have a look at this. Off the top of my head, the problem was related to using astropy 5 with Python 3.7 (maybe 3.8). I can probably tie the version of number to the Python version as well. What version of Python are you using?

@rmathar
Copy link
Author

rmathar commented Dec 15, 2022

Wouldn't it be the responsibility of the .toml file (or whatever type of build-system is used) of the astropy library to define which numpy versions is is pleased with, instead of dragging this into the specifications of every project that uses astropy?

@albireox
Copy link
Member

I think 0.7.0 should fix this. It seems at some point astropy fixed the issue that initially forced me to specify different astropy versions for different Python versions. As long as one runs astropy 5.1 or above it should be fine. Note that I dropped Python 3.7 since that was limiting some numpy and scipy versions and it was annoying to install in some systems for which there weren't wheels. Let me know if that's an issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants