Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge LCO changes #5

Merged
merged 40 commits into from
Sep 1, 2022
Merged

Merge LCO changes #5

merged 40 commits into from
Sep 1, 2022

Conversation

albireox
Copy link
Member

@albireox albireox commented Sep 1, 2022 •
edited

  • Split configuration between APO and LCO.
  • Various changes to account for differences at LCO.
  • Add lcotcc.py to apply corrections at LCO.
  • Move most of the astrometry.net and fitting code to coordio.
  • Implement full PID loop with K, Ti and Td terms.
  • Separate RA/Dec corrections and PID coefficients.

@albireox
Different camera config for APO and LCO
fddfa70
@albireox
Do not check FFS at LCO
a7f8382
@albireox
Updated values for LCO
aca11b5
@albireox
Output correction_applied keywords if --no-apply
e71a7e9
@albireox
Add corrections for LCO
0ad9880
@albireox
Split configuration files for APO and LCO
2fe8aea
@albireox
Attempt at fixing typing errors
77832f5
@albireox
Allow to use a single point per camera for astrometric fit
f99d7eb
@albireox
Use SEXtractor for LCO
fee5177
@albireox
Use 50% percentile to reject FWHM outliers
d4c1b3c
@albireox
Apply corrections if all are negative
ffcf6ea
@albireox
Fix getting focus_weight
69dbdea
@albireox
Allow to skip doing focus fit
c445584
@albireox
Another case of observatory lingering
a764f15
@albireox
Revert typing cleanup that caused a bug
fcefb82
@albireox
Back to using marginal
f891ef4
@albireox
Randomly changing the focus position of GFA2
ec16dcb
@albireox
Another attempt at cleaning up extraction code from typing errors
8b0d837
@albireox
Add initial enabled axes
e69b2bf
@albireox
Allow to set k>1 with warning
3a8919a
@albireox
Update camera focus offset for LCO
b870d5c
@albireox
Do not scale RMS
8fe4b3e
@albireox
A bit simpler expression for checking if the guider is stopping
e8971e3
@albireox
Move astrometry.net and fitting to coordio
50ce440
@albireox
Remove etc
e8a8558
@albireox
Separate RA/Dec corrections and PID coeffs
82f9391
@albireox
Implemented proper PID loop with Kp, Ki, Kd
985c3e6
@albireox
Fix call to apply_correction_lco
73517f7
@albireox
Also add PID loop for APO corrections
a926712
@albireox
Allow to add a delay between acquire exposures
a8ddc88
@albireox albireox merged commit a3fd6bb into main Sep 1, 2022
@albireox albireox deleted the lco branch September 1, 2022 00:25
albireox added a commit that referenced this pull request Sep 1, 2022
@albireox
Revert "Merge LCO changes (#5)"
29d33a1 
This reverts commit a3fd6bb.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@albireox