Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change how parser is used #18

Closed
albireox opened this issue Jan 14, 2020 · 0 comments · Fixed by #25
Closed

Change how parser is used #18

albireox opened this issue Jan 14, 2020 · 0 comments · Fixed by #25

Comments

@albireox
Copy link
Member

Right now the user needs to import from clu import command_parser and append commands to it. That's not very clear. While keeping that option, it would be better to allow the user to send their own command group (as long as it uses CluGroup).

It would need to:

  • If the actor receives an empty parser keyword, use the internal command_parser.
  • If it's not empty, check that it uses CluGroup.
  • See if the new command group implements ping, help, and other commands that are normally defined by CLU. If they are implemented, do nothing, otherwise add them from the CLU command parser.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant