Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Store replies #48

Closed
albireox opened this issue Jan 22, 2021 · 0 comments · Fixed by #55
Closed

Store replies #48

albireox opened this issue Jan 22, 2021 · 0 comments · Fixed by #55
Assignees
@albireox
Labels
enhancement New feature or request

Comments

@albireox
Copy link
Member

It would be useful to store the replies a command is issuing. This would allow introspection for example to see if an error (but not fail) has been output.

A possible implementation is that BaseActor.write (or BaseActor._create_reply would create a generic Reply object. The subclasses would super() that method to get the Reply, output it in the way that's particular to the actor, and return the Reply.
@albireox albireox self-assigned this Feb 18, 2021
@albireox albireox added the enhancement New feature or request label Feb 18, 2021
@albireox albireox mentioned this issue Feb 18, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@albireox albireox

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Store replies in Command sdss/clu
1 participant
@albireox