Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update use of database in FPS #121

Merged
merged 9 commits into from May 24, 2021
Merged

Update use of database in FPS #121

merged 9 commits into from May 24, 2021

Conversation

albireox
Copy link
Member

Fixes #120

@codecov
Copy link

codecov bot commented May 24, 2021

Codecov Report

Merging #121 (42d1725) into main (871240d) will decrease coverage by 0.10%.
The diff coverage is 55.45%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #121      +/-   ##
==========================================
- Coverage   65.73%   65.62%   -0.11%     
==========================================
  Files          18       19       +1     
  Lines        2498     2560      +62     
  Branches      464      467       +3     
==========================================
+ Hits         1642     1680      +38     
- Misses        666      692      +26     
+ Partials      190      188       -2     
Impacted Files Coverage Δ
python/jaeger/fps.py 54.01% <39.62%> (-1.48%) ⬇️
python/jaeger/database.py 69.64% <69.64%> (ø)
python/jaeger/positioner.py 61.53% <100.00%> (ø)
python/jaeger/utils/helpers.py 68.58% <0.00%> (+0.64%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 871240d...42d1725. Read the comment docs.

@albireox albireox merged commit eac61c2 into main May 24, 2021
@albireox albireox deleted the albireox/issue120 branch May 24, 2021 00:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove database / fps_RTConfig?
1 participant