Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FVC snapshot command #186

Merged
merged 8 commits into from Jun 8, 2022
Merged

FVC snapshot command #186

merged 8 commits into from Jun 8, 2022

Conversation

albireox
Copy link
Member

@albireox albireox commented Jun 8, 2022

This PR is an initial step in a larger change that would take an FVC measurement after a collision detected and provide information about the likelihood of that collision being real.

These changes refactor the fvc loop command, moving the logic to a separate function. It also allows to use any BaseConfiguration object with the FVC class. Finally, it introduces an fvc snapshot command that creates a configuration from the current positions and takes the equivalent of an fvc loop --no-apply.

@codecov
Copy link

codecov bot commented Jun 8, 2022

Codecov Report

Merging #186 (d8093b4) into main (25226f5) will decrease coverage by 0.1%.
The diff coverage is 23.0%.

❗ Current head d8093b4 differs from pull request most recent head c616713. Consider uploading reports for the commit c616713 to get more accurate results

@@           Coverage Diff           @@
##            main    #186     +/-   ##
=======================================
- Coverage   45.7%   45.6%   -0.0%     
=======================================
  Files         42      42             
  Lines       6148    6165     +17     
  Branches    1201    1202      +1     
=======================================
+ Hits        2805    2811      +6     
- Misses      3064    3075     +11     
  Partials     279     279             
Impacted Files Coverage Δ
python/jaeger/fvc.py 23.2% <20.0%> (+0.5%) ⬆️
python/jaeger/actor/commands/fvc.py 24.7% <23.4%> (+0.4%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 25226f5...c616713. Read the comment docs.

@albireox albireox merged commit a889431 into main Jun 8, 2022
@albireox albireox deleted the fvc-snapshot branch June 8, 2022 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant