Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support NaN values in categorical variables #78

Closed
csala opened this issue Nov 5, 2020 · 0 comments · Fixed by #77
Closed

Support NaN values in categorical variables #78

csala opened this issue Nov 5, 2020 · 0 comments · Fixed by #77
Assignees
@fealho
Labels
internal The issue doesn't change the API or functionality
Milestone
0.2.2

Comments

@csala
Copy link
Contributor

csala commented Nov 5, 2020

As it has been reported several times (#21, #48, #75), the current implementation of CTGAN does not support NaN values on categorical values because the OneHotEncoder that is being used cannot handle them.

Let's switch to the OneHotEncodingTransformer implemented in RDT, which sets the NaN values as just another category.
@csala csala added the internal The issue doesn't change the API or functionality label Nov 5, 2020
@csala csala mentioned this issue Nov 5, 2020
Merged
@fealho fealho closed this as completed in #77 Nov 6, 2020
@csala csala changed the title Replace sklearn OneHotEncoder with RDT OneHotEncodingTransformer Support NaN values in categorical variables Nov 10, 2020
@csala csala added this to the 0.2.2 milestone Nov 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fealho fealho

Labels
internal The issue doesn't change the API or functionality
Projects
None yet
Milestone
0.2.2
Development

Successfully merging a pull request may close this issue.

Switch to RDT one hot transformer sdv-dev/CTGAN
2 participants
@csala @fealho