Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initialize variable before reference #104

Merged
merged 1 commit into from Jun 23, 2021
Merged

Initialize variable before reference #104

merged 1 commit into from Jun 23, 2021

Conversation

katxiao
Copy link
Contributor

@katxiao katxiao commented Jun 22, 2021

Fix bug UnboundLocalError: local variable 'normalized_score' referenced before assignment by initializing normalized_score to None.

@katxiao katxiao requested a review from csala June 22, 2021 20:31
csala
csala approved these changes Jun 23, 2021
View reviewed changes
Copy link
Contributor

@csala csala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch

@csala csala merged commit 51e6cc2 into master Jun 23, 2021
@csala csala deleted the variable-fix branch June 23, 2021 14:11
@fealho fealho added the bug Something isn't working label Aug 20, 2021
@fealho fealho added this to the 0.4.1 milestone Aug 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@csala csala csala approved these changes

Assignees

@katxiao katxiao

Labels
bug Something isn't working
Projects
None yet
Milestone
0.4.1
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@katxiao @csala @fealho