Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save version #229

Merged
merged 3 commits into from Sep 16, 2022
Merged

Save version #229

merged 3 commits into from Sep 16, 2022

Conversation

katxiao
Copy link
Contributor

@katxiao katxiao commented Sep 15, 2022

Save sdmetrics version being used and validate upon load

@katxiao katxiao requested a review from a team as a code owner September 15, 2022 20:00
@katxiao katxiao requested review from fealho and removed request for a team September 15, 2022 20:00
Copy link
Member

@fealho fealho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@codecov-commenter
Copy link

Codecov Report

Base: 70.18% // Head: 70.69% // Increases project coverage by +0.50% 🎉

Coverage data is based on head (e5a1cd6) compared to base (62e6b73).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #229      +/-   ##
==========================================
+ Coverage   70.18%   70.69%   +0.50%     
==========================================
  Files          70       71       +1     
  Lines        2482     2525      +43     
==========================================
+ Hits         1742     1785      +43     
  Misses        740      740              
Impacted Files Coverage Δ
sdmetrics/multi_table/__init__.py 100.00% <ø> (ø)
sdmetrics/reports/single_table/plot_utils.py 100.00% <ø> (ø)
sdmetrics/single_table/__init__.py 100.00% <ø> (ø)
sdmetrics/multi_table/multi_single_table.py 82.27% <100.00%> (+0.46%) ⬆️
sdmetrics/reports/multi_table/quality_report.py 98.19% <100.00%> (+0.07%) ⬆️
sdmetrics/reports/single_table/quality_report.py 99.12% <100.00%> (+0.05%) ⬆️
sdmetrics/single_column/__init__.py 100.00% <100.00%> (ø)
sdmetrics/single_column/statistical/__init__.py 100.00% <100.00%> (ø)
...etrics/single_column/statistical/range_coverage.py 100.00% <100.00%> (ø)
sdmetrics/single_table/multi_single_column.py 90.62% <100.00%> (+0.46%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@katxiao katxiao merged commit 0899c67 into master Sep 16, 2022
@katxiao katxiao deleted the save-version branch September 16, 2022 19:02
@katxiao katxiao added this to the 0.7.0 milestone Sep 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants