Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for new metadata #253

Merged
merged 5 commits into from Nov 1, 2022
Merged

Fixes for new metadata #253

merged 5 commits into from Nov 1, 2022

Conversation

katxiao
Copy link
Contributor

@katxiao katxiao commented Oct 26, 2022

No description provided.

@katxiao katxiao requested a review from a team as a code owner October 26, 2022 20:33
@katxiao katxiao requested review from fealho and removed request for a team October 26, 2022 20:33
@codecov-commenter
Copy link

codecov-commenter commented Oct 28, 2022

Codecov Report

Base: 74.42% // Head: 74.48% // Increases project coverage by +0.06% 🎉

Coverage data is based on head (f40efef) compared to base (2c264e1).
Patch coverage: 73.03% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #253      +/-   ##
==========================================
+ Coverage   74.42%   74.48%   +0.06%     
==========================================
  Files          74       74              
  Lines        2932     2975      +43     
==========================================
+ Hits         2182     2216      +34     
- Misses        750      759       +9     
Impacted Files Coverage Δ
...dmetrics/reports/single_table/diagnostic_report.py 97.24% <ø> (ø)
sdmetrics/single_table/efficacy/mlefficacy.py 0.00% <0.00%> (ø)
sdmetrics/single_table/privacy/base.py 33.07% <33.33%> (+0.53%) ⬆️
sdmetrics/reports/multi_table/diagnostic_report.py 95.13% <40.00%> (-1.99%) ⬇️
sdmetrics/reports/multi_table/quality_report.py 96.49% <40.00%> (-1.71%) ⬇️
sdmetrics/multi_table/detection/parent_child.py 42.10% <50.00%> (ø)
sdmetrics/timeseries/base.py 43.33% <50.00%> (+1.95%) ⬆️
..._table/statistical/cardinality_shape_similarity.py 84.44% <68.75%> (-10.43%) ⬇️
...le/statistical/cardinality_statistic_similarity.py 77.27% <68.75%> (-6.07%) ⬇️
sdmetrics/utils.py 89.62% <83.33%> (-0.81%) ⬇️
... and 7 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@fealho fealho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! I'd get a second review from someone else though, there were quite a few changes.

@katxiao katxiao merged commit 16992e1 into master Nov 1, 2022
@katxiao katxiao deleted the new-metadata-fixes branch November 1, 2022 15:11
@@ -9,7 +9,7 @@
import plotly.figure_factory as ff
from pandas.core.tools.datetimes import _guess_datetime_format_for_array

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

12

@katxiao katxiao added this to the 0.8.0 milestone Nov 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants