Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Visualization get_column_pair_plot: update parameter name to column_names #258

Closed
npatki opened this issue Nov 10, 2022 · 0 comments · Fixed by #259
Closed

Visualization get_column_pair_plot: update parameter name to column_names #258

npatki opened this issue Nov 10, 2022 · 0 comments · Fixed by #259
Assignees
Labels
bug Something isn't working feature:reports Related to any of the generated reports
Milestone

Comments

@npatki
Copy link
Contributor

npatki commented Nov 10, 2022

Environment Details

Please indicate the following details about the environment in which you found the bug:

  • SDMetrics version: 0.7 and 0.8
  • Python version: Any
  • Operating System: Any

Error Description

The docs for utils.get_column_pair_plot mention that the column names should be given as a parameter column_names. This yields an error. The method seems to expect columns as the parameter name instead.

Expected Results

We should change the parameter to be consistent with the docs:

(a) We use columns_names(s) whenever the user is providing a string with the names, instead of the actual column data
(b) The other visualization method get_column_plot has the desired column_name so it would be consistent.

@npatki npatki added bug Something isn't working feature:reports Related to any of the generated reports labels Nov 10, 2022
@katxiao katxiao added this to the 0.8.1 milestone Dec 10, 2022
@katxiao katxiao self-assigned this Dec 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working feature:reports Related to any of the generated reports
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants