Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Method get_column_pair_plot: Does not plot synthetic data if datetime column is formatted as a string #310

Closed
npatki opened this issue Feb 17, 2023 · 0 comments · Fixed by #312
Assignees
Labels
bug Something isn't working
Milestone

Comments

@npatki
Copy link
Contributor

npatki commented Feb 17, 2023

Environment Details

  • SDMetrics version: 0.9.1
  • Python version: Any
  • Operating System: Any

Error Description

Starting from SDV 1.0, users will provide a new metadata format. The current version of SDMetrics (0.9.1) already supports this format.

However, I am having an issue when the datetime columns are present in a string format such as: "27 Dec 2020" (format string ="%d %b %Y")

Steps to reproduce

Replicate using SDV 1.0

from sdv.datasets.demo import download_demo
from sdv.lite import SingleTablePreset
from sdv.evaluation.single_table import get_column_pair_plot

real_data, metadata = download_demo(
    modality='single_table',
    dataset_name='fake_hotel_guests'
)

synthesizer = SingleTablePreset(metadata, name='FAST_ML')
synthesizer.fit(real_data)
synthetic_data = synthesizer.sample(num_rows=500)

fig = get_column_pair_plot(
    real_data=real_data,
    synthetic_data=synthetic_data,
    column_names=['checkin_date', 'amenities_fee'],
    metadata=metadata
)

Observe that only the real data shows up in the plot. The synthetic data is missing:

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants