Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More accurate progress bar for single table Quality Report #361

Closed
npatki opened this issue Jun 6, 2023 · 0 comments · Fixed by #378
Closed

More accurate progress bar for single table Quality Report #361

npatki opened this issue Jun 6, 2023 · 0 comments · Fixed by #378
Assignees
Labels
data:single-table Related to tabular datasets feature:reports Related to any of the generated reports feature request Request for a new feature
Milestone

Comments

@npatki
Copy link
Contributor

npatki commented Jun 6, 2023

Problem Description

The current progress bar always increments in 4 steps (no matter how many columns I have) and doesn't give me much insight into the progress.

Expected behavior

Instead of a single progress bar, we can show 2 progress instead: One for the Column Shapes property and one for Column Pair Trends.

  • Column Shapes: Increment through each of the columns. A table with n columns will have a progress bar that increments n times.
  • Column Pair Trends: Increment through each unique pair of columns. A table with n columns will have a progress bar that increments n(n-1)/2 times.

Example

report.generate(real_data, synthetic_data, metadata, verbose=True)
Generating report ...
(1/2) Evaluating Column Shapes: 100%|██████████| 25/25 [00:00<00:00,  7.09it/s]
(2/2) Evaluating Column Pair Trends: 100%|██████████| 325/325 [00:00<00:00,  7.09it/s]

Overall Quality Score: 82.84%

Properties:
- Column Shapes: 82.78%
- Column Pair Trends: 82.9%
@npatki npatki added feature request Request for a new feature data:single-table Related to tabular datasets feature:reports Related to any of the generated reports labels Jun 6, 2023
@npatki npatki added this to the 0.10.2 milestone Jun 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:single-table Related to tabular datasets feature:reports Related to any of the generated reports feature request Request for a new feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants