Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't modify the rounding in the quality report #401

Closed
npatki opened this issue Jul 25, 2023 · 0 comments · Fixed by #410
Closed

Don't modify the rounding in the quality report #401

npatki opened this issue Jul 25, 2023 · 0 comments · Fixed by #410
Assignees
Labels
bug Something isn't working feature:reports Related to any of the generated reports
Milestone

Comments

@npatki
Copy link
Contributor

npatki commented Jul 25, 2023

SDMetrics version: Development (master branch)

The dev version of the quality report shows scores that are rounded differently than before. We should avoid making unnecessary changes like this and stick to what we currently have (in the 0.10.1 release).

We have observed incorrect rounding in 2 places.

The get_properties() function

This function should return a DataFrame with the full property score. It is the only way a user can programmatically access each property score so we should make sure they can access the detailed float value.

Observed: In the dev version, the scores are rounded to 2 decimal digits
image

Expected: Don't change what was in 0.10.1. The method should return the full score
image

Verbosity in the generate() method

As a convenience to the user, we also display the total score and property scores in the generate() method if the verbosity is true. In this case, we should avoid making unnecessary changes to the rounding, and stick to what we had before.

Observed: In the dev version, all scores (overall and property scores) are rounded only to 1 decimal digit
image

Expected: Don't change what was in 0.10.1. The display should be rounded to 2 decimal digits
image

@npatki npatki added bug Something isn't working feature:reports Related to any of the generated reports labels Jul 25, 2023
@npatki npatki added this to the 0.11.0 milestone Jul 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working feature:reports Related to any of the generated reports
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants