Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create SingleTablePreset #1079

Closed
amontanez24 opened this issue Oct 20, 2022 · 0 comments
Closed

Create SingleTablePreset #1079

amontanez24 opened this issue Oct 20, 2022 · 0 comments
Assignees
@amontanez24
Labels
feature request Request for a new feature
Milestone
1.0.0

Comments

@amontanez24
Copy link
Contributor

Problem Description

The TabularPreset class should follow the new naming conventions.

  • Create a new file in the lite module called single_table.py
  • Move the code in lite/tabular.py to this new file
  • Rename the TabularPreset to SingleTablePreset
  • Rewrite the code to wrap around the GaussianCopularSynthesizer instead of the old model
  • It should now take in a SingleTableMetadata object
  • Reorder the __init__ params so that the metadata comes first
  • Migrate all tests as well

Expected behavior

from sdv.lite import SingleTablePreset

synthesizer = SingleTablePreset(metadata, name='FAST_ML')
@amontanez24 amontanez24 added the feature request Request for a new feature label Oct 20, 2022
@amontanez24 amontanez24 added this to the 1.0.0 milestone Oct 20, 2022
@amontanez24 amontanez24 mentioned this issue Nov 14, 2022
Merged
@amontanez24 amontanez24 self-assigned this Mar 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@amontanez24 amontanez24

Labels
feature request Request for a new feature
Projects
None yet
Milestone
1.0.0
Development

No branches or pull requests
1 participant
@amontanez24