Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect sdtype specified in demo dataset student_placements_pii #1206

Closed
npatki opened this issue Jan 27, 2023 · 1 comment
Closed

Incorrect sdtype specified in demo dataset student_placements_pii #1206

npatki opened this issue Jan 27, 2023 · 1 comment
Assignees
Labels
bug Something isn't working resolution:resolved The issue was fixed, the question was answered, etc.
Milestone

Comments

@npatki
Copy link
Contributor

npatki commented Jan 27, 2023

Environment Details

  • SDV version: 1.0.0 (in progress)
  • Python version: 3.8
  • Operating System: Linux (Colab Notebook)

Error Description

The single table demo dataset student_placements_pii includes a column named address that represents a PII street address. The metadata included in the demo specifies this column as:

'address': {
  'sdtype': 'text',
  'regex_format': '[A-Za-z]{5}'
}

But under the new metadata description, it should be specified as a a PII column of address sdtype instead.

'address': {
  'sdtype': 'address',
  'pii': True
}

Steps to reproduce

data, metadata = download_demo(
    modality='single_table',
    dataset_name='student_placements_pii',
)
print(metadata.to_dict()['columns']['address'])
@npatki npatki added the bug Something isn't working label Jan 27, 2023
@npatki npatki added this to the 1.0.0 milestone Jan 27, 2023
@npatki
Copy link
Contributor Author

npatki commented Jan 27, 2023

This fix was made in the S3 bucket and has been verified.

@npatki npatki closed this as completed Jan 27, 2023
@npatki npatki added the resolution:resolved The issue was fixed, the question was answered, etc. label Jan 27, 2023
@amontanez24 amontanez24 self-assigned this Mar 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working resolution:resolved The issue was fixed, the question was answered, etc.
Projects
None yet
Development

No branches or pull requests

2 participants