Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Function get_available_demos crashes if a dataset's num-tables or size-MB cannot be found #1215

Closed
npatki opened this issue Jan 30, 2023 · 0 comments
Assignees
Labels
bug Something isn't working
Milestone

Comments

@npatki
Copy link
Contributor

npatki commented Jan 30, 2023

Environment Details

  • SDV version: 1.0.0 (in progress)
  • Python version: 3.8
  • Operating System: Linux (Colab Notebook)

Error Description

The get_available_demos reads datasets from the public S3 bucket and uses meta information to read and fill out the num_tables and size_MB. If this information isn't found, the entire get_available_demos crashes.

Proposed Fix

Instead of crashing the entire function, the row that describes the dataset should include NaN for the num_tables and size_MB columns.

dataset_name size_MB num_tables
KRK_v1 0.07 1
adult 3.90 NaN
alarm NaN NaN
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants