Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change 'text' sdtype to 'id' #1324

Closed
amontanez24 opened this issue Mar 21, 2023 · 0 comments · Fixed by #1338
Closed

Change 'text' sdtype to 'id' #1324

amontanez24 opened this issue Mar 21, 2023 · 0 comments · Fixed by #1338
Assignees
@frances-h
Labels
feature request Request for a new feature
Milestone
1.0.0

Comments

@amontanez24
Copy link
Contributor

Problem Description

As a user, it isn't clear which sdtype to use for id columns. Text seems like it would be for free text responses.

Expected behavior

  • Change any references and checks in the metadata for 'text' as an sdtype to 'id'
  • Validate that any keys are either sdtype 'id' or one of the natural (faker) types. Keys cannot be categorical, boolean, numerical or datetime. Currently we only check for boolean and categorical.
  • Change any references in the DataProcessor
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@frances-h frances-h

Labels
feature request Request for a new feature
Projects
None yet
Milestone
1.0.0
Development

Successfully merging a pull request may close this issue.

Text to id changes sdv-dev/SDV
2 participants
@amontanez24 @frances-h