Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecated locale warning #1400

Closed
npatki opened this issue Apr 28, 2023 · 0 comments · Fixed by #1401
Closed

Deprecated locale warning #1400

npatki opened this issue Apr 28, 2023 · 0 comments · Fixed by #1401
Assignees
Labels
bug Something isn't working feature:metadata Related to describing the dataset
Milestone

Comments

@npatki
Copy link
Contributor

npatki commented Apr 28, 2023

  • SDV version: 1.1.0 (in development)

Error Description

The SDV version in development is showing a warning every time the metadata is being validated.

/usr/local/lib/python3.10/dist-packages/faker/providers/person/fr_QC/__init__.py:10: UserWarning: fr_QC locale is deprecated. Please use fr_CA.
  warnings.warn("fr_QC locale is deprecated. Please use fr_CA.")

This is happening because we recently merged changes to detect Faker functions in different locales for validation purposes. We now iterate through all the locales to check validity -- however, some locales are deprecated so it raises a warning.

The warning is especially confusing for the user, because I have never explicitly put fr_QC anywhere in my metadata.

Proposed Fixes

  1. We can just catch the warning in the function, or
  2. We can explicitly exclude the fr_QC locale since we know it causes a problem
@npatki npatki added bug Something isn't working feature:metadata Related to describing the dataset labels Apr 28, 2023
@npatki npatki added this to the 1.1.0 milestone Apr 28, 2023
@frances-h frances-h self-assigned this Apr 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working feature:metadata Related to describing the dataset
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants